Force refresh kills the app - HELP

Hey Steve - I e-mailed this one to you, but for the benefit of everyone else ...

I changed a series (Holmes on homes) to DVD Order and then did a force refresh on it. It pulls down the data fine and then crashes with the following error message. I have no idea whether the force refresh did it, the new data was corrupt (i.e. dodgy characters) or something completely unrelated has happened.


************** Exception Text **************
System.InvalidOperationException: Failed to compare two elements in the array. ---> System.FormatException: Input string was not in a correct format.
at System.Number.StringToNumber(String str, NumberStyles options, NumberBuffer& number, NumberFormatInfo info, Boolean parseDecimal)
at System.Number.ParseDouble(String value, NumberStyles options, NumberFormatInfo numfmt)
at System.Double.Parse(String s, NumberStyles style, NumberFormatInfo info)
at TVRename.ProcessedEpisode.DVDOrderSorter(ProcessedEpisode e1, ProcessedEpisode e2)
at System.Array.FunctorComparer`1.Compare(T x, T y)
at System.Collections.Generic.ArraySortHelper`1.QuickSort[TValue](T[] keys, TValue[] values, Int32 left, Int32 right, IComparer`1 comparer)
--- End of inner exception stack trace ---
at System.Collections.Generic.ArraySortHelper`1.QuickSort[TValue](T[] keys, TValue[] values, Int32 left, Int32 right, IComparer`1 comparer)
at System.Collections.Generic.ArraySortHelper`1.Sort[TValue](T[] keys, TValue[] values, Int32 index, Int32 length, IComparer`1 comparer)
at System.Collections.Generic.ArraySortHelper`1.Sort(T[] items, Int32 index, Int32 length, IComparer`1 comparer)
at System.Array.Sort[T](T[] array, Int32 index, Int32 length, IComparer`1 comparer)
at System.Collections.Generic.List`1.Sort(Comparison`1 comparison)
at TVRename.TVDoc.GenerateEpisodes(ShowItem si, SeriesInfo ser, Int32 snum, Boolean supressErrors, Boolean applyRules)
at TVRename.TVDoc.GenerateEpisodeDict(ShowItem si, Boolean cachedOnly, Boolean suppressErrors)
at TVRename.TVDoc.GenDict(Boolean cachedOnly, Boolean suppressErrors)
at TVRename.TVDoc.DoDownloadsFG(ProgressBar pbProgress)
at TVRename.UI.bnMyShowsRefresh_Click(Object sender, EventArgs e)
at System.Windows.Forms.Control.OnClick(EventArgs e)
at System.Windows.Forms.Button.OnClick(EventArgs e)
at System.Windows.Forms.Button.OnMouseUp(MouseEventArgs mevent)
at System.Windows.Forms.Control.WmMouseUp(Message& m, MouseButtons button, Int32 clicks)
at System.Windows.Forms.Control.WndProc(Message& m)
at System.Windows.Forms.ButtonBase.WndProc(Message& m)
at System.Windows.Forms.Button.WndProc(Message& m)
at System.Windows.Forms.Control.ControlNativeWindow.OnMessage(Message& m)
at System.Windows.Forms.Control.ControlNativeWindow.WndProc(Message& m)
at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)


I got it working again last night by deleting the current xml files and restoring previous ones, but now it just keeps crashing with the same error. HELP.

I got your email.. I should have a chance to look into it tonight.

If you can find the series that has "DVD Order" turned on, turning that off will make the crash go away for now. Either do it by editing the show in My Shows, or finding the entry in TVRenameSettings.xml.

I've got a reasonable idea as to what's happening, so it'll be easy fixed.

Fixed in the version (alpha 9) I'll be uploading later tonight. It was due to trying to do DVD order on a show that had empty DVD order information coming from thetvdb.com, rather than no DVD order information - which is what I expected.

Incidentally: The DVD order will be applied as soon as you close the "Edit show" dialog. In the case of Holmes on Homes, there is no DVD order information, so it will be unchanged (for now no warning is given to the user, but I will do that eventually.).

OK - well there is dvd order on some seasons (season 3 & 4) but not on all of them, which is what probably confused the shit out of tvrenamer. Maybe some logic to apply the aired order if no dvd order comes down for a season?

I knew it wasn't dvd order by itself as I applied it to Firefly and it worked no problem.

Incidentally: The DVD order will be applied as soon as you close the "Edit show" dialog.

I didn't see that happen with Firefly (have you just added that?), including after a standard refresh. The only solution I found was the force refresh which I luckily discovered by clicking on the flush cache & it told me how to do it.

Anyway I took your advice to get me going again. Thanks for the super continued response time.

One more very minor thing that I have seen. When I choose to change the name of a series on the series edit page it's all good. If I ever open the series edit page again it seems to revert the name back to the default one again. Just a minor thing that I have noticed a couple of times.

The auto-re-sorting I think has been in for the last couple of alphas. There definitely was a point where it wasn't in, though a normal refresh should have got it. Anyway, it definitely should be re-sorting immediately now.

I'll look into the user-set name being forgotten.

Can you let me know if the forgetting of the custom series name still happens? It seems to be ok for me. Does it always happen, or is it intermittant? Do you have to quit and restart TVRename for it to happen? Thanks!

Custom series name - Well, yes and no. It seems when the name is basically the same it forgets the customisation. I have changed "Lost" to "LOST" and it forgets it each time I open the edit series dialog. If I don't notice, then the next time I check for renames it wants to rename all my LOST episodes.

Ah! I see. Fixed in the next version I upload tonight/tomorrow.