Weirdness found so far

ScoopD

05-10-2008 19:12:19

Hey Steve, It's looking pretty good & I think we are down to the nitty gritty.

Missing doesn't collect all the missing episodes - I have a one season series with some episodes. The "Folder per season" is unticked, but "do renaming" and "do missing check" are both ticked, yet the missing eps are not showing up in the missing tab.

Renaming merged episodes - if I merge two episodes the offered new name only refers to one. eg. I merge ep 19 & 20. On the My Shows tab you see E19-E20, but the offered rename is just E19.

Alternate episode order - One of the options on TheTVDB are alternate episode order from DVD release. It would be cool to be able to apply this order rather than in some cases having to apply about 13 rules to get the order the right way for how I already have it. I would think this option would be implemented on a season by season basis, so would appear on the "edit season rules" dialog. For examples of how different it can be see "Holmes on Homes" Season 3, or "Firefly"

Apostrophe weird - I have found a bunch of times that renaming wants to rename a word like "let's" to "let-'s" but not on every apostrophe. (example Family Guy S02E14) I think there must be some garbage characters coming down from TheTVDB doing that programming thing where you put a \ before a "special" character which is then being converted to a dash. Don't know if there is any way to deal with this easily though.

Leading and Trailing spaces - I have come across a heap of episodes with leading or trailing spaces. Can you trim the episode name without making the match to TheTVDB break?

sstteevvee

05-10-2008 20:21:06

Thanks for those. None of them look too bad. :)

Missing doesn't collect all the missing episodes - I have a one season series with some episodes...

Can you tell me what the one-season-series is that's not working for missing and renaming, and in particular which episode number is missing that its not noticing? That way I can try it here and see if I get the same problem.

if I merge two episodes the offered new name only refers to one

What naming style are you using? It seems to be ok here. Also, can you let me know the show, season, and start+end numbers for the merge you're trying to do.

DVD episode order

Yeah.. That should be easy to do. For each show I'll make it so you can choose "DVD" or "Default", and then if you choose DVD and there is DVD order information available, it'll sort on that before doing anything else.

Apostrophe weird

Yep. thetvdb is being weird. The data coming back from them is: Let\'s Go, so tvrename replaces the illegal-for-filname \ with a -. It seems that all single and double-quotes in thetvdb data has a backslash before it. Easily fixed.

Leading and Trailing spaces

Yep. Easily removed. Won't break anything, as I only match on the season and episode numbers, never the name.

ScoopD

05-10-2008 21:11:14


Can you tell me what the one-season-series is that's not working for missing and renaming, and in particular which episode number is missing that its not noticing? That way I can try it here and see if I get the same problem.


The one I noticed it on, as I have new episodes in my Finding folder that are not being picked up, is "All You Need Is Love: The Story of Popular Music" I have episodes 1-7 already and am slowly one by one adding more. None of the missing episodes i.e. 8-17, are showing up as missing.


What naming style are you using? It seems to be ok here. Also, can you let me know the show, season, and start+end numbers for the merge you're trying to do.


I am using the last naming style in the list "Show Name S03E14 - Episode Name". The example I can give is "Avatar: The Last Airbender" Season 1 episodes 19 & 20 merged i.e. Start 19, End 20.

Thanks again mate. Numerous Beers coming your way.

sstteevvee

05-10-2008 21:23:43

The example I can give is "Avatar: The Last Airbender" Season 1 episodes 19 & 20 merged i.e. Start 19, End 20.

In the episode guide, does it show those episodes as merged? I get:

E19-E20 - The Siege of the North (Part 1) + The Siege of the North (Part 2)

All You Need Is Love: The Story of Popular Music

Ok.. Happens here for me too. I shall investigate!

ScoopD

05-10-2008 22:44:50


In the episode guide, does it show those episodes as merged? I get: E19-E20 - The Siege of the North (Part 1) + The Siege of the North (Part 2)


Yep shows up fine in the ep guide, it is just the actual rename which is wrong - the suggested episode name is right, but the number is wrong. It only shows the one episode.
Easier if I tell you exactly -

My current filename is "Avatar- The Last Airbender S01E19-E20 - The Siege of the North (Part 1) + The Siege of the North (Part 2)" and it wants to change it to "Avatar- The Last Airbender S01E19 - The Siege of the North (Part 1) + The Siege of the North (Part 2)"
Note - it wants to change E19-E20 to just E19

sstteevvee

06-10-2008 00:58:05

I've got everything done (fingers crossed).

- Not picking up missing episodes - fixed.

- DVD episode order - added (edit the show in "My Shows" and click the checkbox). At the moment you it is set at the show level, and it is applied to all seasons. If you think its worth doing it season-by-season, I can move it.

- Apostrophe weirdness - fixed. Anything on disk will be fixed the next time you do a rename.

- Leading and trailing spaces - fixed. The next rename you do will fix 'em all.

- E19 vs. E19-20 - um.. fixed, perhaps. Can you give the latest version a go. I think I saw the same thing happen here, but then changed something that made it fix itself the next time I did a rename. Let me know if it still happens in the latest version (alpha 7).

Grab the latest version here.

ScoopD

07-10-2008 23:45:10

Ahh, OK. Well where I also see (first saw) the double episode issue is in the Finding and Organising tab.

I was using Finding and Organising to re-organise my files. It wanted to rename a double episode to a single number. As I had already set this as a double episode and saw that the renaming tab was working I allowed it to rename and move the file, then did a rename check and it changed it back again - in the new correct location. Bit round about, but we got there in the end.

So do you have different code on the renaming from the Finding and Organising tab to the renaming tab? I would have thought you would be calling the same sub-function in both forms? Just starting to go beyond VBS etc into the "real world" of programming, so I am interested in your methods. I am an installation builder (mostly MSI) by occupation but we always have to chuck in bits and pieces of code to get stuff to work properly.

sstteevvee

08-10-2008 00:15:33

Hmm.. Ok.. I've only really been testing it using the Renaming tab, so it may be something that only shows up in Finding and Organising. It shouldn't, as both use the same function to generate the new name for an episode.

Behind the scenes: Both functions (renaming / finding&organising) build up a list of things to do. Each item in that list, along with the folder where the episode belongs, has an associated Episode object that has all the info about the episode (e.g. episode number, ending episode number if its a multi-part file, name, season, what show and season it belongs to, overview, etc.). When it comes to doing the renaming/moving/copying, it then asks another function "given this episode and the default naming style of such-and-such, what should the name be?". That function then returns "ShowName - S03E12 - Blah blah" (or S03E12-13 if its a combined episode).

..and right now the lightbulb above my head goes off :idea:, and looking at th code I find that finding&organising uses the Episode object that doesn't have the ending episode number, while renaming uses the derived one that extends it to have extra information over and above what thetvdb provides (including ending episode number.)

*changes two words in his code*

Fixed! :) Whenever alpha 9 goes up (maybe this friday/weekend), it'll be in there. In the meantime, just follow a find&organise with a rename, and it'll sort itself out.